drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #775: DRILL-5326: Unit tests failures related to the SERV...
Date Tue, 07 Mar 2017 23:59:12 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/775#discussion_r104812618
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/metadata/ServerMetaProvider.java
---
    @@ -76,7 +76,7 @@
           .setReadOnly(false)
           .setGroupBySupport(GroupBySupport.GB_UNRELATED)
           .setLikeEscapeClauseSupported(true)
    -      .setNullCollation(NullCollation.NC_AT_END)
    +      .setNullCollation(NullCollation.NC_HIGH)
    --- End diff --
    
    @jinfengni Agree with Paul. The difference between NC_HIGH and NC_AT_END for the DESC
case. I checked that Drill uses NC_HIGH for sorting. Please, see it at [jira](https://issues.apache.org/jira/browse/DRILL-5326?focusedCommentId=15900411&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15900411),
since github doesn't show formatted code correctly in the comments.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message