drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #772: DRILL-5316: Check drillbitsVector count from zoo_ge...
Date Tue, 07 Mar 2017 06:04:22 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/772#discussion_r104594602
  
    --- Diff: contrib/native/client/src/clientlib/zookeeperClient.cpp ---
    @@ -138,6 +138,11 @@ int ZookeeperClient::getAllDrillbits(const std::string& connectStr,
std::vector<
                 DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "\t Unshuffled Drillbit id: "
<< drillbits[i] << std::endl;)
             }
         }
    +    else{
    --- End diff --
    
    I'm not sure the check should be in the zookeeper client, but instead in the drill client:
the zookeeper client is just returning the content of the zookeeper tree, and there's no error
from the zookeeper client point of view (so no need to disconnect/reconnect).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message