drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #767: DRILL-5226: Managed external sort fixes
Date Fri, 03 Mar 2017 22:10:25 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/767#discussion_r104229270
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java
---
    @@ -303,5 +307,9 @@ public int getRecordCount() {
         public int getBatchCount() {
           return batchCount;
         }
    +
    +    public long getBatchSize() {
    --- End diff --
    
    This should be better named as getMaxBatchSize()



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message