drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Wed, 01 Mar 2017 09:00:14 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r103636512
  
    --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryContextInformation.java
---
    @@ -51,6 +51,7 @@ public static QueryContextInformation getDefaultInstance()
         private int timeZone;
         private String defaultSchemaName;
         private String sessionId;
    +    private int hllAccuracy;
    --- End diff --
    
    hllAccuracy is required within the HLL UDFs. The only way I found to pass information
inside the UDFs is by injecting the `@Inject ContextInformation` available in the `UDFUtilities.java`.
    Hence, I define it in the QueryContext eventually passing it to the `ContextInformation`.
Please suggest if there is a better way to do the same.hllAccuracy is required within the
HLL UDFs. The only way I found to pass information inside the UDFs is by injecting the `@Inject
ContextInformation` available in the `UDFUtilities.java`.
    Hence, I define it in the QueryContext eventually passing it to the `ContextInformation`.
Please suggest if there is a better way to do the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message