drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Wed, 01 Mar 2017 05:00:06 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r103611021
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
---
    @@ -82,11 +82,18 @@
       private boolean specialBatchSent = false;
       private static final int SPECIAL_BATCH_COUNT = 1;
     
    -  public StreamingAggBatch(StreamingAggregate popConfig, RecordBatch incoming, FragmentContext
context) throws OutOfMemoryException {
    +  public StreamingAggBatch(StreamingAggregate popConfig, RecordBatch incoming, FragmentContext
context)
    +      throws OutOfMemoryException {
         super(popConfig, context);
         this.incoming = incoming;
       }
     
    +  public StreamingAggBatch(StreamingAggregate popConfig, RecordBatch incoming, FragmentContext
context,
    +                           final boolean buildSchema) throws OutOfMemoryException {
    --- End diff --
    
    I am not familiar with the entire inner implementation of StreamingAggBatch. @amansinha100
could you please explain why we need another buildSchema flag?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message