drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Wed, 01 Mar 2017 04:19:33 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r103608069
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
---
    @@ -169,4 +175,43 @@ private static boolean containIdentity(List<? extends RexNode>
exps,
         }
         return true;
       }
    +
    +  /**
    +   * Returns whether statistics-based estimates or guesses are used by the optimizer
    +   * */
    +  public static boolean guessRows(RelNode rel) {
    +    final PlannerSettings settings =
    +            rel.getCluster().getPlanner().getContext().unwrap(PlannerSettings.class);
    +    if (!settings.useStatistics()) {
    +      return true;
    +    }
    +    if (rel instanceof RelSubset) {
    --- End diff --
    
    Added comment explaining the special treatment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message