drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #765: DRILL-5293: Change the seed of the hash function fo...
Date Wed, 01 Mar 2017 02:28:52 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/765#discussion_r103599295
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashPrelUtil.java
---
    @@ -89,14 +91,15 @@ public LogicalExpression createCall(String funcName, List<LogicalExpression>
inp
        */
       public static <T> T createHashExpression(
           List<T> inputExprs,
    +      T seed,
           HashExpressionCreatorHelper<T> helper,
           boolean hashAsDouble) {
     
         assert inputExprs.size() > 0;
     
         final String functionName = hashAsDouble ? HASH32_DOUBLE_FUNCTION_NAME : HASH32_FUNCTION_NAME;
     
    -    T func = helper.createCall(functionName,  ImmutableList.of(inputExprs.get(0)));
    +    T func = helper.createCall(functionName,  ImmutableList.of(inputExprs.get(0), seed
));
    --- End diff --
    
    Must be, as two code lines below there is another call to createCall() with three parameters
(the last of type T). Also looked -- the files (of one kind) were copied (from the other one).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message