drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #765: DRILL-5293: Change the seed of the hash function fo...
Date Wed, 01 Mar 2017 02:12:13 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/765#discussion_r103595799
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java
---
    @@ -119,7 +118,8 @@ public Prel visitExchange(ExchangePrel prel, Void value) throws RuntimeException
           }
     
           outputFieldNames.add(HashPrelUtil.HASH_EXPR_NAME);
    -      updatedExpr.add(HashPrelUtil.createHashBasedPartitionExpression(distFieldRefs,
hashHelper));
    +      final RexNode distSeed = rexBuilder.makeExactLiteral(BigDecimal.valueOf(1301011));
// distribution seed
    --- End diff --
    
    This could just be makeBigIntLiteral() instead of makeExactLiteral since the seed is always
an int/bigint


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message