Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-761-drill@git.apache.org>
In-Reply-To: <git-pr-761-drill@git.apache.org>
Subject: [GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort
Content-Type: text/plain
Message-Id: <20170228000645.5F650DFB0E@git1-us-west.apache.org>
Date: Tue, 28 Feb 2017 00:06:45 +0000 (UTC)
archived-at: Tue, 28 Feb 2017 00:06:48 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/761#discussion_r103331438
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java ---
    @@ -219,7 +220,18 @@
     
       private BatchSchema schema;
     
    +  /**
    +   * Incoming batches buffered in memory prior to spilling
    +   * or an in-memory merge.
    +   */
    +
       private LinkedList<BatchGroup.InputBatch> bufferedBatches = Lists.newLinkedList();
    +
    +  /**
    +   * Spilled runs consisting of a large number of spilled
    +   * in-memory batches.
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---