Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-756-drill@git.apache.org>
In-Reply-To: <git-pr-756-drill@git.apache.org>
Subject: [GitHub] drill pull request #756: DRILL-5195: Publish Operator and MajorFragment Stat...
Content-Type: text/plain
Message-Id: <20170224184519.5AD03DFFD9@git1-us-west.apache.org>
Date: Fri, 24 Feb 2017 18:45:19 +0000 (UTC)
archived-at: Fri, 24 Feb 2017 18:45:23 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/756#discussion_r103004559
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java ---
    @@ -179,12 +207,47 @@ public String getMetricsTable() {
           }
           for (final Number value : values) {
             if (value != null) {
    -          builder.appendFormattedNumber(value, null);
    +          builder.appendFormattedNumber(value);
             } else {
    -          builder.appendCell("", null);
    +          builder.appendCell("");
             }
           }
         }
         return builder.build();
       }
    +
    +  private class OverviewTblTxt {
    +    static final String OperatorID = "Operator ID";
    +    static final String Type = "Type";
    +    static final String AvgSetupTime = "Avg Setup Time";
    +    static final String MaxSetupTime = "Max Setup Time";
    +    static final String AvgProcessTime = "Avg Process Time";
    +    static final String MaxProcessTime = "Max Process Time";
    +    static final String MinWaitTime = "Min Wait Time";
    +    static final String AvgWaitTime = "Avg Wait Time";
    +    static final String MaxWaitTime = "Max Wait Time";
    +    static final String PercentFragmentTime = "% Fragment Time";
    +    static final String PercentQueryTime = "% Query Time";
    +    static final String Rows = "Rows";
    +    static final String AvgPeakMemory = "Avg Peak Memory";
    +    static final String MaxPeakMemory = "Max Peak Memory";
    +  }
    +
    +  private class OverviewTblTooltip {
    +    static final String OperatorID = "Operator ID";
    +    static final String Type = "Operator Type";
    +    static final String AvgSetupTime = "Average Time in setting up fragments";
    +    static final String MaxSetupTime = "Longest Time a fragment took in setup";
    +    static final String AvgProcessTime = "Average processing time for a fragment";
    +    static final String MaxProcessTime = "Longest Time a fragment took to process";
    +    static final String MinWaitTime = "Shortest time a fragment spent in waiting for data";
    +    static final String AvgWaitTime = "Average wait time for a fragment";
    +    static final String MaxWaitTime = "Longest Time a fragment spent in waiting data";
    --- End diff --
    
    "Time" --> "time"
    
    "waiting data" --> "waiting for data" or just "waiting"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---