Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: ppadma <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-757-drill@git.apache.org>
In-Reply-To: <git-pr-757-drill@git.apache.org>
Subject: [GitHub] drill pull request #757: DRILL-5290: Provide an option to build operator tab...
Content-Type: text/plain
Message-Id: <20170223003003.06237DFF09@git1-us-west.apache.org>
Date: Thu, 23 Feb 2017 00:30:02 +0000 (UTC)
archived-at: Thu, 23 Feb 2017 00:30:05 -0000

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/757#discussion_r102611281
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -413,4 +413,8 @@
     
       String DYNAMIC_UDF_SUPPORT_ENABLED = "exec.udf.enable_dynamic_support";
       BooleanValidator DYNAMIC_UDF_SUPPORT_ENABLED_VALIDATOR = new BooleanValidator(DYNAMIC_UDF_SUPPORT_ENABLED, true, true);
    +
    +  String USE_DYNAMIC_UDFS = "exec.udf.use_dynamic";
    --- End diff --
    
    I did not use the existing option "exec.udf.enable_dynamic_support" because if that option is enabled and then disabled later, expectation is that dynamic UDFs added in that window continue to be available and working even after disabling.  
    
    All other comments addressed. Please review new diffs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---