Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: laurentgo <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-578-drill@git.apache.org>
In-Reply-To: <git-pr-578-drill@git.apache.org>
Subject: [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Content-Type: text/plain
Message-Id: <20170222005737.DDB90E114F@git1-us-west.apache.org>
Date: Wed, 22 Feb 2017 00:57:37 +0000 (UTC)
archived-at: Wed, 22 Feb 2017 00:57:46 -0000

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r101631177
  
    --- Diff: common/src/main/java/org/apache/drill/common/KerberosUtil.java ---
    @@ -0,0 +1,76 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.common;
    +
    +import static com.google.common.base.Preconditions.checkNotNull;
    +import static com.google.common.base.Preconditions.checkState;
    +
    +public final class KerberosUtil {
    +  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(KerberosUtil.class);
    +
    +  public static final String KERBEROS_SASL_NAME = "GSSAPI";
    +
    +  public static final String KERBEROS_SIMPLE_NAME = "KERBEROS";
    +
    +  public static final String HOSTNAME_PATTERN = "_HOST";
    +
    +  /**
    +   * Returns principal of format primary/instance@REALM.
    +   *
    +   * @param primary non-null primary component
    +   * @param instance non-null instance component
    +   * @param realm non-null realm component
    +   * @return principal of format primary/instance@REALM
    +   */
    +  public static String getPrincipalFromParts(final String primary, final String instance, final String realm) {
    +    return checkNotNull(primary) + "/" +
    +        checkNotNull(instance) + "@" +
    +        checkNotNull(realm);
    +  }
    +
    +  /**
    +   * Expects principal of the format primary/instance@REALM.
    +   *
    +   * @param principal principal
    +   * @return components
    +   */
    +  public static String[] splitPrincipalIntoParts(final String principal) {
    +    final String[] components = principal.split("[/@]");
    +    checkState(components.length == 3);
    +    checkNotNull(components[0]);
    +    checkNotNull(components[1]);
    +    checkNotNull(components[2]);
    +    return components;
    +  }
    +
    +  public static String canonicalizedInstanceName(String instanceName, final String canonicalName) {
    --- End diff --
    
    (style) for consistency, use verb present tense for methods (canonicalizeInstanceName)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---