Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: laurentgo <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-578-drill@git.apache.org>
In-Reply-To: <git-pr-578-drill@git.apache.org>
Subject: [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Content-Type: text/plain
Message-Id: <20170222005735.2EB09E0B49@git1-us-west.apache.org>
Date: Wed, 22 Feb 2017 00:57:35 +0000 (UTC)
archived-at: Wed, 22 Feb 2017 00:57:40 -0000

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r102294263
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnectionConfig.java ---
    @@ -0,0 +1,59 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc.control;
    +
    +import org.apache.drill.exec.exception.DrillbitStartupException;
    +import org.apache.drill.exec.memory.BufferAllocator;
    +import org.apache.drill.exec.proto.CoordinationProtos.DrillbitEndpoint;
    +import org.apache.drill.exec.rpc.BitConnectionConfig;
    +import org.apache.drill.exec.server.BootStrapContext;
    +import org.apache.drill.exec.work.batch.ControlMessageHandler;
    +
    +// package private
    +class ControlConnectionConfig extends BitConnectionConfig {
    +//  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(ControlConnectionConfig.class);
    +
    +  private final ControlMessageHandler handler;
    +
    +  private DrillbitEndpoint localEndpoint;
    +
    +  ControlConnectionConfig(BufferAllocator allocator, BootStrapContext context, ControlMessageHandler handler)
    +      throws DrillbitStartupException {
    +    super(allocator, context);
    +    this.handler = handler;
    +  }
    +
    +  @Override
    +  public String getName() {
    +    return "control"; // unused
    +  }
    +
    +  ControlMessageHandler getMessageHandler() {
    +    return handler;
    +  }
    +
    +  void setLocalEndpoint(DrillbitEndpoint endpoint) {
    --- End diff --
    
    Can we avoid modifying the original config to return the endpoint created by the server? it seems to me that the previous approach sounded safer as config is usually considered immutable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---