Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-580-drill@git.apache.org>
In-Reply-To: <git-pr-580-drill@git.apache.org>
Subject: [GitHub] drill pull request #580: DRILL-4824: JSON with complex nested data produces ...
Content-Type: text/plain
Message-Id: <20170208065104.6D3BCDFBDB@git1-us-west.apache.org>
Date: Wed,  8 Feb 2017 06:51:04 +0000 (UTC)
archived-at: Wed, 08 Feb 2017 06:51:06 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/580#discussion_r100001448
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java ---
    @@ -91,9 +91,7 @@ public void testFieldSelectionBug() throws Exception {
               .baselineColumns("col_1", "col_2")
               .baselineValues(
                   mapOf(),
    -              mapOf(
    -                  "inner_1", listOf(),
    -                  "inner_3", mapOf()))
    +              mapOf())
    --- End diff --
    
    The test file used here is not sufficient to fully test the code change. Perhaps create an additional test, using a new test file, that tests all the variations suggested in the comment below and in the JIRA entry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---