Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: vdiravka <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-520-drill@git.apache.org>
In-Reply-To: <git-pr-520-drill@git.apache.org>
Subject: [GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...
Content-Type: text/plain
Message-Id: <20170206165958.542EBDFF17@git1-us-west.apache.org>
Date: Mon,  6 Feb 2017 16:59:58 +0000 (UTC)
archived-at: Mon, 06 Feb 2017 17:00:01 -0000

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r99624485
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ---
    @@ -760,6 +765,24 @@ public void abort(Executor executor) throws SQLException {
         }
       }
     
    +  @Override
    +  public boolean useAnsiQuotedIdentifiers() throws SQLException {
    +    boolean systemOption = false;
    +    Boolean sessionOption = null;
    +    String sql = String.format("select type, bool_val from sys.options where name = '%s'",
    +        PlannerSettings.ANSI_QUOTES_KEY);
    +    ResultSet rs = executeSql(sql);
    --- End diff --
    
    Done.
    New RPC request is implemented. RPC response returns `ServerProperties` that represent the list of server session options.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---