Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5C130200C31 for ; Wed, 1 Feb 2017 05:04:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5AEF7160B52; Wed, 1 Feb 2017 04:04:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A82BC160B5F for ; Wed, 1 Feb 2017 05:04:48 +0100 (CET) Received: (qmail 50497 invoked by uid 500); 1 Feb 2017 04:04:47 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 49979 invoked by uid 99); 1 Feb 2017 04:04:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Feb 2017 04:04:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1008DDFBDA; Wed, 1 Feb 2017 04:04:47 +0000 (UTC) From: Ben-Zvi To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort Content-Type: text/plain Message-Id: <20170201040447.1008DDFBDA@git1-us-west.apache.org> Date: Wed, 1 Feb 2017 04:04:47 +0000 (UTC) archived-at: Wed, 01 Feb 2017 04:04:49 -0000 Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r98576202 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -63,13 +63,29 @@ String SPOOLING_BUFFER_DELETE = "drill.exec.buffer.spooling.delete"; String SPOOLING_BUFFER_MEMORY = "drill.exec.buffer.spooling.size"; String BATCH_PURGE_THRESHOLD = "drill.exec.sort.purge.threshold"; + + // External Sort Boot configuration + String EXTERNAL_SORT_TARGET_BATCH_SIZE = "drill.exec.sort.external.batch.size"; String EXTERNAL_SORT_TARGET_SPILL_BATCH_SIZE = "drill.exec.sort.external.spill.batch.size"; String EXTERNAL_SORT_SPILL_GROUP_SIZE = "drill.exec.sort.external.spill.group.size"; String EXTERNAL_SORT_SPILL_THRESHOLD = "drill.exec.sort.external.spill.threshold"; String EXTERNAL_SORT_SPILL_DIRS = "drill.exec.sort.external.spill.directories"; String EXTERNAL_SORT_SPILL_FILESYSTEM = "drill.exec.sort.external.spill.fs"; + String EXTERNAL_SORT_SPILL_FILE_SIZE = "drill.exec.sort.external.spill.file_size"; String EXTERNAL_SORT_MSORT_MAX_BATCHSIZE = "drill.exec.sort.external.msort.batch.maxsize"; + String EXTERNAL_SORT_DISABLE_MANAGED = "drill.exec.sort.external.disable_managed"; + String EXTERNAL_SORT_MERGE_LIMIT = "drill.exec.sort.external.merge_limit"; + String EXTERNAL_SORT_MIN_SPILL = "drill.exec.sort.external.spill.min_batches"; + String EXTERNAL_SORT_MAX_SPILL = "drill.exec.sort.external.spill.max_batches"; + String EXTERNAL_SORT_MAX_MEMORY = "drill.exec.sort.external.mem_limit"; + String EXTERNAL_SORT_BATCH_LIMIT = "drill.exec.sort.external.batch_limit"; + + // External Sort Runtime options + + BooleanValidator EXTERNAL_SORT_DISABLE_MANAGED_OPTION = new BooleanValidator("exec.sort.disable_managed", false); --- End diff -- "false" means "enabled", but the Jira says that initially the managed feature would be disabled by default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---