drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #736: DRILL-5238: CTTAS: unable to resolve temporary tabl...
Date Thu, 02 Feb 2017 14:22:33 GMT
GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/736

    DRILL-5238: CTTAS: unable to resolve temporary table if workspace is …

    …indicated without schema
    
    1. Added additional check for passed table is temporary if default workspace is partially
indicated (issue is described in Jira DRILL-5238).
    2. Removed `UserSession.getDefaultSchemaName()` method as it contained exactly the same
logic as `UserSession.getDefaultSchemaPath()`.
    3. Since `UserSession.properties` are set using builder, they are not required but when
not set, they may cause NPE when `UserSession.getProp()` method is called. Moved `UserSession.properties`
into constructor.
    4. Unit test for partial schema usage with temporary table.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-5238

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #736
    
----
commit a787c6c2b49de6b8114f028864ff8d67cc5989be
Author: Arina Ielchiieva <arina.yelchiyeva@gmail.com>
Date:   2017-02-02T11:47:19Z

    DRILL-5238: CTTAS: unable to resolve temporary table if workspace is indicated without
schema

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message