drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #764: DRILL-5301: Server metadata API
Date Tue, 28 Feb 2017 15:39:06 GMT
Github user laurentgo commented on a diff in the pull request:

    --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
    @@ -1722,8 +1774,68 @@ void DrillClientImpl::shutdownSocket(){
         DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Socket shutdown" << std::endl;)
    +namespace { // anonymous
    --- End diff --
    no, it's an anonymous namespace: the actual name is generated at compilation time, and
it prevents symbols to leak from outside object file, or clash with other symbols (if not
declared static).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message