drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #758: DRILL-5287: Provide option to skip updates of ephem...
Date Tue, 28 Feb 2017 02:36:23 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/758#discussion_r103364711
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
---
    @@ -280,8 +281,15 @@ public void interrupted(final InterruptedException ex) {
         }
       }
     
    -  QueryState updateEphemeralState(final QueryState queryState) {
    -    switch (queryState) {
    +  void updateEphemeralState(final QueryState queryState) {
    +      // If query is already in zk transient store, ignore the transient state update
option.
    +      // Else, they will not be removed from transient store upon completion.
    +      if (transientProfiles.get(stringQueryId) == null &&
    --- End diff --
    
    Why not just check the option?
    
    `transientProfiles.get(stringQueryId)` is quite expensive itself ([contacts ZooKeeper
and deserializes data](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZkEphemeralStore.java#L61)).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message