drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort
Date Tue, 28 Feb 2017 00:06:45 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/761#discussion_r103330903
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java
---
    @@ -357,9 +393,13 @@ public SpillSet(FragmentContext context, PhysicalOperator popConfig)
{
         } else {
           fileManager = new HadoopFileManager(spillFs);
         }
    -    FragmentHandle handle = context.getHandle();
    -    spillDirName = String.format("%s_major%s_minor%s_op%s", QueryIdHelper.getQueryId(handle.getQueryId()),
    -        handle.getMajorFragmentId(), handle.getMinorFragmentId(), popConfig.getOperatorId());
    +    spillDirName = String.format(
    --- End diff --
    
    Either format is fine. Go ahead and overwrite this change with your preferred format when
you commit your work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message