drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #763: DRILL-5208: Finding path to java executable should ...
Date Sun, 26 Feb 2017 17:38:29 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    --- Diff: distribution/src/resources/drill-config.sh ---
    @@ -367,12 +375,18 @@ if [ -z "$JAVA_HOME" ]; then
     # Now, verify that 'java' binary exists and is suitable for Drill.
    -if $is_cygwin; then
    -  JAVA_BIN="java.exe"
    -  JAVA_BIN="java"
    +# If we started with `which java` above, use that path (after replacing
    +# symlinks. If we started with JAVA_HOME, try in bin. Doing so handles
    --- End diff --
    Close the brace.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message