drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #761: DRILL-5284: Roll-up of final fixes for managed sort
Date Sat, 25 Feb 2017 03:36:25 GMT
Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/761#discussion_r103067184
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
    @@ -219,7 +220,18 @@
     
       private BatchSchema schema;
     
    +  /**
    +   * Incoming batches buffered in memory prior to spilling
    +   * or an in-memory merge.
    +   */
    +
       private LinkedList<BatchGroup.InputBatch> bufferedBatches = Lists.newLinkedList();
    +
    +  /**
    +   * Spilled runs consisting of a large number of spilled
    +   * in-memory batches.
    --- End diff --
    
    "spilled in-memory" is an oxymoron :-) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message