drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #756: DRILL-5195: Publish Operator and MajorFragment Stat...
Date Fri, 24 Feb 2017 20:39:06 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/756#discussion_r103028294
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
    @@ -35,6 +38,10 @@
     public class FragmentWrapper {
       private final MajorFragmentProfile major;
       private final long start;
    +  private final Locale currentLocale = Locale.getDefault();
    +  private final String pattern = "dd-MMM-yyyy HH:mm:ss";
    +  private final SimpleDateFormat simpleDateFormat = new SimpleDateFormat(
    --- End diff --
    
    Oh. I thought the locale did that. But, as long as these timestamps are aligned with the
timestamps on the server (where the logs reside), this should be fine, right? Otherwise, this
is useful for only _running_ queries and we can skip it altogether. What do you suggest, @paul-rogers
?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message