drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #756: DRILL-5195: Publish Operator and MajorFragment Stat...
Date Fri, 24 Feb 2017 18:45:19 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/756#discussion_r103003252
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
    @@ -136,26 +240,60 @@ public String getContent() {
             biggestBatches = Math.max(biggestBatches, batches);
           }
     
    -      builder.appendCell(new OperatorPathBuilder().setMajor(major).setMinor(minor).build(),
null);
    -      builder.appendCell(minor.getEndpoint().getAddress(), null);
    -      builder.appendMillis(minor.getStartTime() - start, null);
    -      builder.appendMillis(minor.getEndTime() - start, null);
    -      builder.appendMillis(minor.getEndTime() - minor.getStartTime(), null);
    +      builder.appendCell(new OperatorPathBuilder().setMajor(major).setMinor(minor).build());
    +      builder.appendCell(minor.getEndpoint().getAddress());
    +      builder.appendMillis(minor.getStartTime() - start);
    +      builder.appendMillis(minor.getEndTime() - start);
    +      builder.appendMillis(minor.getEndTime() - minor.getStartTime());
     
    -      builder.appendFormattedInteger(biggestIncomingRecords, null);
    -      builder.appendFormattedInteger(biggestBatches, null);
    +      builder.appendFormattedInteger(biggestIncomingRecords);
    +      builder.appendFormattedInteger(biggestBatches);
     
    -      builder.appendTime(minor.getLastUpdate(), null);
    -      builder.appendTime(minor.getLastProgress(), null);
    +      builder.appendTime(minor.getLastUpdate());
    +      builder.appendTime(minor.getLastProgress());
     
    -      builder.appendBytes(minor.getMaxMemoryUsed(), null);
    -      builder.appendCell(minor.getState().name(), null);
    +      builder.appendBytes(minor.getMaxMemoryUsed());
    +      builder.appendCell(minor.getState().name());
         }
     
         for (final MinorFragmentProfile m : incomplete) {
    -      builder.appendCell(major.getMajorFragmentId() + "-" + m.getMinorFragmentId(), null);
    +      builder.appendCell(major.getMajorFragmentId() + "-" + m.getMinorFragmentId());
           builder.appendRepeated(m.getState().toString(), null, NUM_NULLABLE_FRAGMENTS_COLUMNS);
         }
         return builder.build();
       }
    +
    +  private class OverviewTblTxt {
    +    static final String MajorFragment = "Major Fragment";
    +    static final String MinorFragmentsReporting = "Minor Fragments Reporting";
    +    static final String FirstStart = "First Start";
    +    static final String LastStart = "Last Start";
    +    static final String FirstEnd = "First End";
    +    static final String LastEnd = "Last End";
    +    static final String MinRuntime = "Min Runtime";
    +    static final String AvgRuntime = "Avg Runtime";
    +    static final String MaxRuntime = "Max Runtime";
    +    static final String PercentBusy = "% Busy";
    +    static final String LastUpdate = "Last Update";
    +    static final String LastProgress = "Last Progress";
    +    static final String MaxPeakMemory = "Max Peak Memory";
    +  }
    +
    +  private class OverviewTblTooltip {
    +    static final String MajorFragment = "Major Fragment ID";
    +    static final String MinorFragmentsReporting = "Number of Minor Fragments Spawned";
    +    static final String FirstStart = "Earliest start of a fragment since query submission";
    +    static final String LastStart = "Latest start of a fragment since query submission";
    +    static final String FirstEnd = "Earliest completion time a fragment";
    --- End diff --
    
    "time a" --> "time of a".
    
    Or, better, "Time at which the first fragment completed."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message