drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #756: DRILL-5195: Publish Operator and MajorFragment Stat...
Date Fri, 24 Feb 2017 13:50:18 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/756#discussion_r102943494
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
    @@ -179,12 +207,47 @@ public String getMetricsTable() {
           }
           for (final Number value : values) {
             if (value != null) {
    -          builder.appendFormattedNumber(value, null);
    +          builder.appendFormattedNumber(value);
             } else {
    -          builder.appendCell("", null);
    +          builder.appendCell("");
             }
           }
         }
         return builder.build();
       }
    +
    +  private class OverviewTblTxt {
    +    static final String OperatorID = "Operator ID";
    --- End diff --
    
    Is there any reason why variables start with upper case letter instead of lower case (ex:
operatorID)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message