drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #701: DRILL-4963: Fix issues with dynamically loaded over...
Date Fri, 24 Feb 2017 12:37:30 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/701#discussion_r102921207
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
    @@ -140,27 +142,39 @@ public void register(DrillOperatorTable operatorTable) {
       }
     
       /**
    -   * Using the given <code>functionResolver</code>
    -   * finds Drill function implementation for given <code>functionCall</code>.
    -   * If function implementation was not found,
    -   * loads all missing remote functions and tries to find Drill implementation one more
time.
    +   * First attempts to finds the Drill function implementation that matches the name,
arg types and return type.
    +   * If exact function implementation was not found,
    +   * syncs local function registry with remote function registry if needed
    +   * and tries to find function implementation one more time
    --- End diff --
    
    As agreed, we'll gone leave this implementation till MVCC will be implemented. MVCC will
ensure we have up-to-date function registry before query planning or execution stages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message