drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Fri, 24 Feb 2017 03:53:43 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r102866471
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java
---
    @@ -29,13 +29,15 @@
       private final long queryStartTime;
       private final int rootFragmentTimeZone;
       private final String sessionId;
    +  private final int hllAccuracy;
     
       public ContextInformation(final UserCredentials userCredentials, final QueryContextInformation
queryContextInfo) {
         this.queryUser = userCredentials.getUserName();
         this.currentDefaultSchema = queryContextInfo.getDefaultSchemaName();
         this.queryStartTime = queryContextInfo.getQueryStartTime();
         this.rootFragmentTimeZone = queryContextInfo.getTimeZone();
         this.sessionId = queryContextInfo.getSessionId();
    +    this.hllAccuracy = queryContextInfo.getHllAccuracy();
    --- End diff --
    
    The query context is very general and is probably not the place to store specific options
such as the hllAccuracy. The operator and/or factory can get the value directly from the option
manager.
    
    Actually, any stats options should be set on the operator definition itself (`StatisticsAggregate`,
etc.) so that all fragments use the same value: the one selected when creating the plan. This
behavior would mimic how we set memory for sort operators, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message