drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #753: DRILL-5260: Extend "Cluster Fixture" test framework
Date Thu, 23 Feb 2017 21:08:37 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/753#discussion_r102589695
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
    @@ -99,33 +111,83 @@
           // behavior. Production default is DEFAULT_SCAN_THREADS
     
           put(ExecConstants.SCAN_THREADPOOL_SIZE, 4);
    +
    +      // Define a useful root location for the ZK persistent
    +      // storage. Profiles will go here when running in distributed
    +      // mode.
    +
    +      put(ZookeeperPersistentStoreProvider.DRILL_EXEC_SYS_STORE_PROVIDER_ZK_BLOBROOT,
"/tmp/drill/log");
         }
       };
     
       public static final String DEFAULT_BIT_NAME = "drillbit";
     
       private DrillConfig config;
    -  private Map<String,Drillbit> bits = new HashMap<>();
    +  private Map<String, Drillbit> bits = new HashMap<>();
       private Drillbit defaultDrillbit;
       private BufferAllocator allocator;
       private boolean ownsZK;
       private ZookeeperHelper zkHelper;
       private RemoteServiceSet serviceSet;
    -  private String dfsTestTmpSchemaLocation;
    +  private File dfsTestTempDir;
       protected List<ClientFixture> clients = new ArrayList<>();
    +  private boolean usesZk;
    +  private boolean preserveLocalFiles;
    +  private boolean isLocal;
    +
    +  /**
    +   * Temporary directories created for this test cluster.
    +   * Each is removed when closing the cluster.
    +   */
    +
    +  private List<File> tempDirs = new ArrayList<>();
    +
    +  ClusterFixture(FixtureBuilder builder) {
    +
    +    String zkConnect = configureZk(builder);
    +    try {
    +      createConfig(builder, zkConnect);
    --- End diff --
    
    In createConfig we are calling `getServiceSetWithFullCache(config, allocator)`. But we
are creating `allocator` later on.  We should assign allocator before calling above method.
But allocator creation also takes in config so probably we have to do inside `createConfig`
method. On a side note I don't see `getServiceSetWithFullCache(config, allocator)` using allocator
or config anyway. Not sure why we are passing in first place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message