drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Wed, 22 Feb 2017 23:41:35 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r102604228
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -390,4 +391,15 @@
     
       String DYNAMIC_UDF_SUPPORT_ENABLED = "exec.udf.enable_dynamic_support";
       BooleanValidator DYNAMIC_UDF_SUPPORT_ENABLED_VALIDATOR = new BooleanValidator(DYNAMIC_UDF_SUPPORT_ENABLED,
true, true);
    +
    +  /**
    +   * Option whose value is a long value representing the number of bits required for
computing ndv (using HLL)
    +   */
    +  LongValidator NDV_MEMORY_LIMIT = new PositiveLongValidator("exec.statistics.ndv_memory_limit",
30, 20);
    --- End diff --
    
    We are not mixing different lengths during the same run. The session setting at the foreman
would be passed along in the plan fragment - so non-foreman fragments will use the same value.
Also, we do not mix lengths across different runs. So this should not be an issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message