drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #757: DRILL-5290: Provide an option to build operator tab...
Date Wed, 22 Feb 2017 23:13:14 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/757#discussion_r102598925
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
    @@ -91,7 +91,12 @@ public QueryContext(final UserSession session, final DrillbitContext
drillbitCon
         executionControls = new ExecutionControls(queryOptions, drillbitContext.getEndpoint());
         plannerSettings = new PlannerSettings(queryOptions, getFunctionRegistry());
         plannerSettings.setNumEndPoints(drillbitContext.getBits().size());
    -    table = new DrillOperatorTable(getFunctionRegistry(), drillbitContext.getOptionManager());
    +
    +    if (getOption(ExecConstants.USE_DYNAMIC_UDFS).bool_val) {
    --- End diff --
    
    + `getOption` uses queryOptions. Is that intended?
    + If so, avoid calling methods in this class in ctor. Use `queryOptions.getOption(...)`
    + Change declaration to `BooleanValidator USE_DYNAMIC_UDFS_VALIDATOR ...` to avoid `.bool_val`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message