drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Wed, 22 Feb 2017 00:57:35 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r101121400
  
    --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
    @@ -412,37 +427,155 @@ connectionStatus_t DrillClientImpl::validateHandshake(DrillUserProperties*
prope
         if(ret!=CONN_SUCCESS){
             return ret;
         }
    -    if(this->m_handshakeStatus != exec::user::SUCCESS){
    -        switch(this->m_handshakeStatus){
    -            case exec::user::RPC_VERSION_MISMATCH:
    -                DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Invalid rpc version.  Expected
"
    -                    << DRILL_RPC_VERSION << ", actual "<< m_handshakeVersion
<< "." << std::endl;)
    -                return handleConnError(CONN_BAD_RPC_VER,
    -                        getMessage(ERR_CONN_BAD_RPC_VER, DRILL_RPC_VERSION,
    -                            m_handshakeVersion,
    -                            this->m_handshakeErrorId.c_str(),
    -                            this->m_handshakeErrorMsg.c_str()));
    -            case exec::user::AUTH_FAILED:
    -                DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Authentication failed." <<
std::endl;)
    -                return handleConnError(CONN_AUTH_FAILED,
    -                        getMessage(ERR_CONN_AUTHFAIL,
    -                            this->m_handshakeErrorId.c_str(),
    -                            this->m_handshakeErrorMsg.c_str()));
    -            case exec::user::UNKNOWN_FAILURE:
    -                DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Unknown error during handshake."
<< std::endl;)
    -                return handleConnError(CONN_HANDSHAKE_FAILED,
    -                        getMessage(ERR_CONN_UNKNOWN_ERR,
    -                            this->m_handshakeErrorId.c_str(),
    -                            this->m_handshakeErrorMsg.c_str()));
    -            default:
    -                break;
    +
    +    switch(this->m_handshakeStatus) {
    +        case exec::user::SUCCESS:
    +            // reset io_service after handshake is validated before running queries
    +            m_io_service.reset();
    +            return CONN_SUCCESS;
    +        case exec::user::RPC_VERSION_MISMATCH:
    +            DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Invalid rpc version.  Expected
"
    +                << DRILL_RPC_VERSION << ", actual "<< m_handshakeVersion
<< "." << std::endl;)
    +            return handleConnError(CONN_BAD_RPC_VER, getMessage(ERR_CONN_BAD_RPC_VER,
DRILL_RPC_VERSION,
    +                                                                m_handshakeVersion,
    +                                                                this->m_handshakeErrorId.c_str(),
    +                                                                this->m_handshakeErrorMsg.c_str()));
    +        case exec::user::AUTH_FAILED:
    +            DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Authentication failed." <<
std::endl;)
    +            return handleConnError(CONN_AUTH_FAILED, getMessage(ERR_CONN_AUTHFAIL,
    +                                                                this->m_handshakeErrorId.c_str(),
    +                                                                this->m_handshakeErrorMsg.c_str()));
    +        case exec::user::UNKNOWN_FAILURE:
    +            DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Unknown error during handshake."
<< std::endl;)
    +            return handleConnError(CONN_HANDSHAKE_FAILED, getMessage(ERR_CONN_UNKNOWN_ERR,
    +                                                                     this->m_handshakeErrorId.c_str(),
    +                                                                     this->m_handshakeErrorMsg.c_str()));
    +        case exec::user::AUTH_REQUIRED:
    +            DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Server requires SASL authentication."
<< std::endl;)
    +            return handleAuthentication(properties);
    +        default:
    +            DRILL_MT_LOG(DRILL_LOG(LOG_TRACE) << "Unknown return status." <<
std::endl;)
    +            return handleConnError(CONN_HANDSHAKE_FAILED, getMessage(ERR_CONN_UNKNOWN_ERR,
    +                                                                     this->m_handshakeErrorId.c_str(),
    +                                                                     this->m_handshakeErrorMsg.c_str()));
    +    }
    +}
    +
    +connectionStatus_t DrillClientImpl::handleAuthentication(const DrillUserProperties *userProperties)
{
    +    try {
    +        m_saslAuthenticator = new SaslAuthenticatorImpl(userProperties);
    --- End diff --
    
    - maybe we should use smart pointers
    - I'm not strongly opinionated against exceptions in C++, but this is not a common pattern
in drill code base


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message