drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Wed, 22 Feb 2017 00:57:35 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r102278730
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractClientConnection.java
---
    @@ -0,0 +1,61 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc;
    +
    +import io.netty.channel.socket.SocketChannel;
    +import org.slf4j.Logger;
    +
    +import javax.security.sasl.SaslClient;
    +import javax.security.sasl.SaslException;
    +
    +public abstract class AbstractClientConnection extends AbstractRemoteConnection implements
ClientConnection {
    +//  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(AbstractClientConnection.class);
    +
    +  private SaslClient saslClient;
    +
    +  public AbstractClientConnection(SocketChannel channel, String name) {
    +    super(channel, name);
    +  }
    +
    +  protected abstract Logger getLogger();
    +
    +  @Override
    +  public void setSaslClient(final SaslClient saslClient) {
    +    assert this.saslClient == null;
    +    this.saslClient = saslClient;
    --- End diff --
    
    According to the interface comment, it's supposed to be only set one, but this is not
checked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message