drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #747: DRILL-5257: Run-time control of query profiles
Date Tue, 21 Feb 2017 18:26:28 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/747#discussion_r102278999
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
---
    @@ -853,7 +875,9 @@ public void close() throws Exception {
           // storage write; query completion occurs in parallel with profile
           // persistence.
     
    -      queryManager.writeFinalProfile(uex);
    +      if (profileOption == ProfileOption.ASYNC) {
    +        writeProfile(uex);
    --- End diff --
    
    why not call queryManager.writeFinalProfile directly from here and avoid creating another
function ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message