drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Serhii-Harnyk <...@git.apache.org>
Subject [GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...
Date Fri, 17 Feb 2017 13:50:03 GMT
Github user Serhii-Harnyk commented on a diff in the pull request:

    https://github.com/apache/drill/pull/594#discussion_r101759433
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
    @@ -492,7 +538,19 @@ private void writeDataAllText(MapWriter map, FieldSelection selection,
           }
         }
         map.end();
    +  }
     
    +  /**
    +   * Puts copy of field path list to fieldPathWriter map.
    +   * @param fieldName
    +   */
    +  private void putFieldPath(String fieldName, MapWriter map) {
    --- End diff --
    
    I attached results of testing on the last fix to the Jira. 
    https://drive.google.com/open?id=1l3Dg0DCV3p-OhwA0v6qdl2wGcezXDl5qaUqv56EEBn8
    It should be mentioned that a lot of time goes to the creating fields and them writers.
So times of execution also compared with time of querying files, in which nulls replaced by
varchar.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message