drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Sun, 12 Feb 2017 01:50:58 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillFilterRelBase.java
    @@ -113,6 +114,6 @@ public double getRows() {
             selectivity = filterMaxSelectivityEstimateFactor;
    -    return selectivity*RelMetadataQuery.getRowCount(getInput());
    +    return NumberUtil.multiply(selectivity, RelMetadataQuery.getRowCount(getInput()));
    --- End diff --
    Perhaps explain why we need a number utility to do a multiplication?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message