drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Sat, 11 Feb 2017 21:57:14 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r100676700
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/InternalBatch.java
---
    @@ -54,6 +56,7 @@ public InternalBatch(RecordBatch incoming, VectorWrapper[] ignoreWrappers,
Opera
           this.sv2 = null;
         }
         this.schema = incoming.getSchema();
    +    this.incoming = incoming;
    --- End diff --
    
    Are we sure we want to do this? It seems the semantics are that this is a, well, "internal
batch" a batch used to hold temporary results. By adding the incoming we are binding this
batch to the output of another operator. That seems to defeat the purpose of an internal batch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message