drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Fri, 10 Feb 2017 01:06:52 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r100452345
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
    @@ -61,6 +61,7 @@
     // in fragment contexts
     public class QueryContext implements AutoCloseable, OptimizerRulesContext, SchemaConfigInfoProvider
{
       private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(QueryContext.class);
    +  public enum StatementType {UNKNOWN, ANALYZE, CTAS, EXPLAIN, REFRESH, SELECT, SETOPTION};
    --- End diff --
    
    There are several other SQL statement types which require additional code to figure out
(Please see child classes of DefaultSqlHandler). I have renamed the UNKNOWN type to OTHER.
For now, this is sufficient since there is no custom logic for these statement types e.g.
VIEWs/DESCRIBEs/DROPs. If need be, we can extend the statement types and add the logic to
determine if the new statement type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message