drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet
Date Fri, 10 Feb 2017 00:36:02 GMT
Github user gparai commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
    @@ -77,6 +78,7 @@
       private final SchemaTreeProvider schemaTreeProvider;
       /** Stores constants and their holders by type */
       private final Map<String, Map<MinorType, ValueHolder>> constantValueHolderCache;
    +  private StatementType stmtType = StatementType.UNKNOWN;
    --- End diff --
    Passing it in the constructor seems infeasible because the query context is created much
earlier. However, the statement type is determined after parsing.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message