drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Wed, 08 Feb 2017 17:31:00 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r100122717
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -568,19 +565,13 @@ public void runQuery(QueryType type, List<PlanFragment> planFragments,
UserResul
        * Helper method to generate the UserCredentials message from the properties.
        */
       private UserBitShared.UserCredentials getUserCredentials() {
    -    // If username is not propagated as one of the properties
    -    String userName = "anonymous";
    -
    -    if (props != null) {
    -      for (Property property: props.getPropertiesList()) {
    -        if (property.getKey().equalsIgnoreCase("user") && !Strings.isNullOrEmpty(property.getValue()))
{
    -          userName = property.getValue();
    -          break;
    -        }
    -      }
    +    String userName = properties.getProperty(DrillProperties.USER);
    +    if (Strings.isNullOrEmpty(userName)) {
    +      userName = "anonymous"; // if username is not propagated as one of the properties
    --- End diff --
    
    To keep the functionality as is, not sure was the original intent was.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message