drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #580: DRILL-4824: JSON with complex nested data produces ...
Date Wed, 08 Feb 2017 06:51:04 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/580#discussion_r100001448
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonReader.java
---
    @@ -91,9 +91,7 @@ public void testFieldSelectionBug() throws Exception {
               .baselineColumns("col_1", "col_2")
               .baselineValues(
                   mapOf(),
    -              mapOf(
    -                  "inner_1", listOf(),
    -                  "inner_3", mapOf()))
    +              mapOf())
    --- End diff --
    
    The test file used here is not sufficient to fully test the code change. Perhaps create
an additional test, using a new test file, that tests all the variations suggested in the
comment below and in the JIRA entry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message