drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #739: DRILL-5230: Translation of millisecond duration int...
Date Wed, 08 Feb 2017 01:42:56 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/739#discussion_r99975170
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
    @@ -352,16 +369,26 @@ public String cancelQuery(@PathParam("queryid") String queryId)
{
       private void checkOrThrowProfileViewAuthorization(final QueryProfile profile) {
         if (!principal.canManageProfileOf(profile.getUser())) {
           throw UserException.permissionError()
    -          .message("Not authorized to view the profile of query '%s'", profile.getId())
    -          .build(logger);
    +      .message("Not authorized to view the profile of query '%s'", profile.getId())
    +      .build(logger);
         }
       }
     
       private void checkOrThrowQueryCancelAuthorization(final String queryUser, final String
queryId) {
         if (!principal.canManageQueryOf(queryUser)) {
           throw UserException.permissionError()
    -          .message("Not authorized to cancel the query '%s'", queryId)
    -          .build(logger);
    +      .message("Not authorized to cancel the query '%s'", queryId)
    +      .build(logger);
         }
       }
    +
    +  /**
    +   * Duration format definition
    +   * @author kkhatua
    --- End diff --
    
    My bad. Will fix that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message