drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #:
Date Tue, 07 Feb 2017 06:45:38 GMT
Github user paul-rogers commented on the pull request:

    https://github.com/apache/drill/commit/c16570705a182bf833576a7ddb546665442ef14d#commitcomment-20776570
  
    In exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java:
    In exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
on line 395:
    The problem is... those validators only work for session and system options; not for the
config options used here.
    
    Yes, it would be good to have a global validation mechanism. But, that is what TypeSafe
provides for config parameters. (Though it does not handle min/max.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message