drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...
Date Tue, 07 Feb 2017 05:47:15 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r99747702
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
    @@ -161,6 +161,19 @@ public SqlNode parse(String sql) {
           SqlParser parser = SqlParser.create(sql, parserConfig);
           return parser.parseStmt();
         } catch (SqlParseException e) {
    +
    +      // Attempt to use default back_tick quote character for identifiers, when QUOTING_IDENTIFIERS_CHARACTER
    --- End diff --
    
    is it really a desirable behavior? What's wrong with just returning an error if the quoting
doesn't match what has been asked by the user?
    
    A consequence of that change is that every invalid request will be parsed twice even if
the issue has nothing to do with quoting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message