drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chunhui-shi <...@git.apache.org>
Subject [GitHub] drill pull request #741: DRILL-5196: init MongoDB cluster when run a single ...
Date Sat, 04 Feb 2017 02:22:53 GMT
Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/741#discussion_r99455997
  
    --- Diff: contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
    @@ -204,16 +209,20 @@ private static void cleanup() {
       @BeforeClass
       public static void initMongo() throws Exception {
         synchronized (MongoTestSuit.class) {
    -      if (distMode) {
    -        logger.info("Executing tests in distributed mode");
    -        DistributedMode.setup();
    -      } else {
    -        logger.info("Executing tests in single mode");
    -        SingleMode.setup();
    +      if (initCount.get() == 0) {
    --- End diff --
    
    Then it will increase the count when the init is not done. If init fail in the middle,
then another test has no chance to try.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message