drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #738: DRILL-5190: Display planning time for a query in it...
Date Fri, 03 Feb 2017 19:44:12 GMT
Github user kkhatua commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
    @@ -77,12 +77,14 @@
       public static String getPrettyDuration(long startTimeMillis, long endTimeMillis) {
         long durationInMillis = (startTimeMillis > endTimeMillis ? System.currentTimeMillis()
: endTimeMillis) - startTimeMillis;
    -    long hours = TimeUnit.MILLISECONDS.toHours(durationInMillis);
    +    long days = TimeUnit.MILLISECONDS.toDays(durationInMillis);
    --- End diff --
    @paul-rogers , The format in DRILL-5230 is compacted to an approximation (i.e. we retain
the 2 largest units of time) so as to fit within the cells of a table. 
    This format is more verbose as it gives the complete picture, down to the smallest unit
of time. Do we want to still merge the two into a single utility method?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message