drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328 r4
Date Fri, 03 Feb 2017 18:32:13 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r99393301
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
    @@ -61,6 +61,7 @@
     // in fragment contexts
     public class QueryContext implements AutoCloseable, OptimizerRulesContext, SchemaConfigInfoProvider
{
       private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(QueryContext.class);
    +  public enum StatementType {UNKNOWN, ANALYZE, CTAS, EXPLAIN, REFRESH, SELECT, SETOPTION};
    --- End diff --
    
    We don't have UNKNOWN statements. (Drill created the statement, it should know what it
created.) Perhaps call this `OTHER`?
    
    Or, better, figure out what that other statement type is and include it in the list. Throw
an exception if we find we don't know the statement time because, in that case, something
is wrong in the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message