drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #729: Drill 1328 r4
Date Fri, 03 Feb 2017 18:32:13 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/729#discussion_r99393723
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ---
    @@ -283,4 +286,18 @@ public void close() throws Exception {
           closed = true;
         }
       }
    +
    +  /**
    +  * @param stmtType : The type {@link StatementType} e.g. CTAS, ANALYZE of the statement
    +  */
    +  public void setStatementType(StatementType stmtType) {
    --- End diff --
    
    See comment above. We probably don't want to set the type this way as it suggests that
the type can change over time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message