drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #738: DRILL-5190: Display planning time for a query in it...
Date Fri, 03 Feb 2017 17:50:19 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/738#discussion_r99386366
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
    @@ -77,12 +77,14 @@
        */
       public static String getPrettyDuration(long startTimeMillis, long endTimeMillis) {
         long durationInMillis = (startTimeMillis > endTimeMillis ? System.currentTimeMillis()
: endTimeMillis) - startTimeMillis;
    -    long hours = TimeUnit.MILLISECONDS.toHours(durationInMillis);
    +    long days = TimeUnit.MILLISECONDS.toDays(durationInMillis);
    --- End diff --
    
    This logic more-or-less duplicates that in DRILL-5230. Please pull this logic out into
a common utility, and adopt a common display format.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message