drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sohami <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Fri, 03 Feb 2017 02:13:05 GMT
Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r99257914
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionManager.java
---
    @@ -21,30 +21,28 @@
     import org.apache.drill.exec.proto.CoordinationProtos.DrillbitEndpoint;
     import org.apache.drill.exec.proto.UserBitShared.RpcChannel;
     import org.apache.drill.exec.rpc.ReconnectingConnection;
    -import org.apache.drill.exec.server.BootStrapContext;
     
     public class DataConnectionManager extends ReconnectingConnection<DataClientConnection,
BitClientHandshake>{
    +//  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(DataConnectionManager.class);
    --- End diff --
    
    Please remove this. There are few other places too with this commented lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message