Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: ppadma <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-704-drill@git.apache.org>
In-Reply-To: <git-pr-704-drill@git.apache.org>
Subject: [GitHub] drill pull request #704: DRILL-5125: Provide option to use generic code for ...
Content-Type: text/plain
Message-Id: <20170127220646.96E18DF9FD@git1-us-west.apache.org>
Date: Fri, 27 Jan 2017 22:06:46 +0000 (UTC)
archived-at: Fri, 27 Jan 2017 22:06:49 -0000

Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/704#discussion_r97992444
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/svremover/GenericSV2Copier.java ---
    @@ -0,0 +1,65 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.physical.impl.svremover;
    +
    +import org.apache.drill.exec.ops.FragmentContext;
    +import org.apache.drill.exec.record.RecordBatch;
    +import org.apache.drill.exec.record.VectorWrapper;
    +import org.apache.drill.exec.vector.ValueVector;
    +
    +/**
    + * Generic selection vector 2 copier implementation that can
    + * be used in place of the generated version. Relies on a
    + * virtual function in each value vector to choose the proper
    + * implementation. Tests suggest that this version performs
    + * better than the generated version for queries with many columns.
    + */
    +
    +public class GenericSV2Copier extends CopierTemplate2 {
    +
    +  private ValueVector[] vvOut;
    +  private ValueVector[] vvIn;
    +
    +  @SuppressWarnings("unused")
    +  @Override
    +  public void doSetup(FragmentContext context, RecordBatch incoming,
    +      RecordBatch outgoing) {
    --- End diff --
    
    fix alignment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---